Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 78F4C19179 for ; Tue, 22 Mar 2016 17:07:35 +0000 (UTC) Received: (qmail 16756 invoked by uid 500); 22 Mar 2016 17:07:35 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16730 invoked by uid 500); 22 Mar 2016 17:07:35 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16710 invoked by uid 99); 22 Mar 2016 17:07:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 17:07:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3399728B991; Tue, 22 Mar 2016 17:07:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5492372792426635661==" MIME-Version: 1.0 Subject: Re: Review Request 44994: Added a test for executor shutdown grace period. From: Alexander Rukletsov To: Ben Mahler Cc: haosdent huang , Alexander Rukletsov , mesos Date: Tue, 22 Mar 2016 17:07:34 -0000 Message-ID: <20160322170734.6937.58773@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44994/ X-Sender: Alexander Rukletsov References: <20160321212910.19594.19379@reviews.apache.org> In-Reply-To: <20160321212910.19594.19379@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============5492372792426635661== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ ----------------------------------------------------------- (Updated March 22, 2016, 5:07 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-4949 https://issues.apache.org/jira/browse/MESOS-4949 Repository: mesos Description ------- See summary. Diffs (updated) ----- src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 Diff: https://reviews.apache.org/r/44994/diff/ Testing ------- On Mac OS 10.10.4: `make check` `GTEST_FILTER="*ExecutorShutdownGracePeriod*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov --===============5492372792426635661==--