Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B0B85187CF for ; Tue, 22 Mar 2016 03:34:50 +0000 (UTC) Received: (qmail 42695 invoked by uid 500); 22 Mar 2016 03:34:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 42654 invoked by uid 500); 22 Mar 2016 03:34:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 42639 invoked by uid 99); 22 Mar 2016 03:34:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 03:34:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EF11428B858; Tue, 22 Mar 2016 03:34:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7884001939631412642==" MIME-Version: 1.0 Subject: Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags. From: Jay Guo To: Joris Van Remoortere , Joseph Wu Cc: Benjamin Bannier , Mesos ReviewBot , mesos , Jay Guo Date: Tue, 22 Mar 2016 03:34:48 -0000 Message-ID: <20160322033448.19594.11310@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jay Guo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45018/ X-Sender: Jay Guo References: <20160321140510.19595.97169@reviews.apache.org> In-Reply-To: <20160321140510.19595.97169@reviews.apache.org> Reply-To: Jay Guo X-ReviewRequest-Repository: mesos --===============7884001939631412642== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/ ----------------------------------------------------------- (Updated March 22, 2016, 3:34 a.m.) Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-3481 https://issues.apache.org/jira/browse/MESOS-3481 Repository: mesos Description ------- MESOS-3481 Add const accessor to Master flags. Diffs (updated) ----- src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c Diff: https://reviews.apache.org/r/45018/diff/ Testing ------- make check This getter is used to retrieve the flags from master. Currently, if one wants to access master flags in the test, master flag has to be explicitly created and then passed to `CreateMasterFlags(flags)`. story description: https://issues.apache.org/jira/browse/MESOS-3481 Thanks, Jay Guo --===============7884001939631412642==--