Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBCBE19DD3 for ; Wed, 9 Mar 2016 13:18:47 +0000 (UTC) Received: (qmail 47518 invoked by uid 500); 9 Mar 2016 13:18:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47481 invoked by uid 500); 9 Mar 2016 13:18:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47286 invoked by uid 99); 9 Mar 2016 13:18:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2016 13:18:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A288C2AAB6F; Wed, 9 Mar 2016 13:18:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2070225506148210039==" MIME-Version: 1.0 Subject: Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator. From: Mesos ReviewBot To: Jie Yu , Avinash sridharan , Gilbert Song Cc: Mesos ReviewBot , Qian Zhang , mesos Date: Wed, 09 Mar 2016 13:18:45 -0000 Message-ID: <20160309131845.8638.17044@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44555/ X-Sender: Mesos ReviewBot References: <20160309060132.8639.19496@reviews.apache.org> In-Reply-To: <20160309060132.8639.19496@reviews.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/network/cni.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/network/cni.hpp Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============2070225506148210039== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review122714 ----------------------------------------------------------- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 9, 2016, 6:01 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44555/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 6:01 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented the framework and create() method of "network/cni" isolator. > > > Diffs > ----- > > src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 > src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 > src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44555/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > > --===============2070225506148210039==--