Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4CFE218C55 for ; Sat, 5 Mar 2016 17:31:56 +0000 (UTC) Received: (qmail 74179 invoked by uid 500); 5 Mar 2016 17:31:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74154 invoked by uid 500); 5 Mar 2016 17:31:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74141 invoked by uid 99); 5 Mar 2016 17:31:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Mar 2016 17:31:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4C9DB2AA66B; Sat, 5 Mar 2016 17:31:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7330942247982400075==" MIME-Version: 1.0 Subject: Re: Review Request 44425: Changed mount as writable for bind backend. From: Mesos ReviewBot To: Jiang Yan Xu Cc: Mesos ReviewBot , Guangya Liu , mesos Date: Sat, 05 Mar 2016 17:31:55 -0000 Message-ID: <20160305173155.1648.99464@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44425/ X-Sender: Mesos ReviewBot References: <20160305162047.7389.42967@reviews.apache.org> In-Reply-To: <20160305162047.7389.42967@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============7330942247982400075== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44425/#review122206 ----------------------------------------------------------- Patch looks great! Reviews applied: [44425] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 5, 2016, 4:20 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44425/ > ----------------------------------------------------------- > > (Updated March 5, 2016, 4:20 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4876 > https://issues.apache.org/jira/browse/MESOS-4876 > > > Repository: mesos > > > Description > ------- > > Changed mount as writable for bind backend. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/backends/bind.cpp 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 > src/tests/containerizer/provisioner_backend_tests.cpp d49204f220c6212f83c2adf5544d04b3386c8eb7 > > Diff: https://reviews.apache.org/r/44425/diff/ > > > Testing > ------- > > make > make check > GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="BindBackendTest.ROOT_BindBackend" --verbose > > > Thanks, > > Guangya Liu > > --===============7330942247982400075==--