Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============0818704687678450263=="
MIME-Version: 1.0
Subject: Re: Review Request 44421: Added support for "overlay" keyword.
From: Mesos ReviewBot <reviews@mesos.apache.org>
To: Jie Yu <yujie.jay@gmail.com>, Shuai Lin <linshuai2012@gmail.com>,
 haosdent huang <haosdent@gmail.com>
Cc: Mesos ReviewBot <reviews@mesos.apache.org>,
 Guangya Liu <gyliu513@gmail.com>, mesos <reviews@mesos.apache.org>
Date: Sat, 05 Mar 2016 09:08:42 -0000
Message-ID: <20160305090842.1649.90153@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Mesos ReviewBot <noreply@reviews.apache.org>
References: <20160305080410.1648.71246@reviews.apache.org>
In-Reply-To: <20160305080410.1648.71246@reviews.apache.org>
Reply-To: Mesos ReviewBot <reviews@mesos.apache.org>

--===============0818704687678450263==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review122193
-----------------------------------------------------------


Patch looks great!

Reviews applied: [44421]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 5, 2016, 8:04 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> -----------------------------------------------------------
> 
> (Updated March 5, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
> 
> 
> Bugs: MESOS-4874
>     https://issues.apache.org/jira/browse/MESOS-4874
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 55652540e35f9c451ad85cfead575a788aa3eba1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
> 
> Diff: https://reviews.apache.org/r/44421/diff/
> 
> 
> Testing
> -------
> 
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
> overlay                45056  1 
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev	overlay
> root@mesos002:~/src/
> 
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


--===============0818704687678450263==--