Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============8690333970991368774=="
MIME-Version: 1.0
Subject: Re: Review Request 39939: Make docker_socket option support different
 protocols.
From: Klaus Ma <klaus1982.cn@gmail.com>
To: Timothy Chen <tnachen@apache.org>, Klaus Ma <klaus1982.cn@gmail.com>
Cc: Mesos ReviewBot <reviews@mesos.apache.org>,
 haosdent huang <haosdent@gmail.com>, Guangya Liu <gyliu513@gmail.com>,
 mesos <reviews@mesos.apache.org>
Date: Fri, 04 Mar 2016 01:35:36 -0000
Message-ID: <20160304013536.1648.4368@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Klaus Ma <noreply@reviews.apache.org>
References: <20160222044116.27513.1420@reviews.apache.org>
In-Reply-To: <20160222044116.27513.1420@reviews.apache.org>
Reply-To: Klaus Ma <klaus1982.cn@gmail.com>

--===============8690333970991368774==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 22, 2016, 12:41 p.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437>
> >
> >     I think we need to handle feature interaction with `docker_mesos_image`. Currently, we mount unix socket into container; but it'll failed when using TCP socket.
> 
> haosdent huang wrote:
>     Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a check here?
> 
> haosdent huang wrote:
>     My concern here is if we use host network when we launch slave in docker, use tcp protocol should still works.

When `docker_mesos_image` is enabled, `docker_socket` are mounted into docker by volume which is not worked for TCP ( https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L293 ).

IMO, two options:

1. Highlight in document that TCP docker_socket can not work with `docker_mesos_image`
2. Add logic for `docker_mesos_image`, just pass docker_socket into slave in docker instead of mounting it; we also need to update document that it's user's responsibility to make sure network is accessable.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
-----------------------------------------------------------


On March 4, 2016, 12:40 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
>     https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


--===============8690333970991368774==--