Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============6107222275324536905=="
MIME-Version: 1.0
Subject: Review Request 44275: Fixed flakiness in tests using the scheduler
 library.
From: Anand Mazumdar <mazumdar.anand@gmail.com>
To: Vinod Kone <vinodkone@gmail.com>
Cc: Anand Mazumdar <mazumdar.anand@gmail.com>,
 mesos <reviews@mesos.apache.org>
Date: Wed, 02 Mar 2016 18:21:49 -0000
Message-ID: <20160302182149.1648.65744@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Anand Mazumdar <noreply@reviews.apache.org>
Reply-To: Anand Mazumdar <mazumdar.anand@gmail.com>

--===============6107222275324536905==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44275/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-4029
    https://issues.apache.org/jira/browse/MESOS-4029


Repository: mesos


Description
-------

This change fixes the tests using the scheduler library by
explicitly invoking `stop()` from the testing interface. This
ensures that no further callbacks are delivered to the scheduler.

For one-off async callbacks that are already on the libprocess queue
we need to do a `Clock::settle` to ensure they are executed before
the mock object goes out of scope.


Diffs
-----

  src/tests/mesos.hpp 0c55d5901753dc3f6e71486f727a2af7bd920429 

Diff: https://reviews.apache.org/r/44275/diff/


Testing
-------

make check + Induced a sleep in the async callbacks. Previously, the test used to crash but with the fix it no longer crashes.


Thanks,

Anand Mazumdar


--===============6107222275324536905==--