mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshi Xiao <xia...@gmail.com>
Subject Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
Date Fri, 25 Mar 2016 02:43:32 GMT


> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote:
> > can we ignore .md scan? the .md possible container non-ascii characters.
> 
> Neil Conway wrote:
>     Are non-ASCII characters in .md files actually required? We should be able to use
HTML character entities instead (e.g., `&#1234;`) instead.
> 
> Deshi Xiao wrote:
>     Neil, see this case:
>     
>     quoted from haosdent's comments:
>      If disable no-ascii characters, we could not use emoji and some languages which
contains no-ascii characters. For the powered-by-mesos.md and user-groups.html.md, this hard
limit seems inconvenient.
> 
> haosdent huang wrote:
>     Still could convert them to unicode code and represented by html character entities.
Just looks confuse and not straightforward.

same here same concerns


- Deshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124992
-----------------------------------------------------------


On 三月 23, 2016, 2:46 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> -----------------------------------------------------------
> 
> (Updated 三月 23, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent huang, Neil Conway,
and Deshi Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review request tries to add a commit hook for checking non-ascii
> characters. It scans .cpp, .hpp, .cc, .h files and report
> error if non-ascii characters exists.
> 
> As part of this review request, two non-ascii characters are identified
> in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
> accordingly.
> 
> Note: .md scan is skipped based on feedback from review request.
> 
> 
> Diffs
> -----
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 
>   support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
>   support/non-ascii.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and found two non ascii characters in docs/versioning.md (fixed as part
of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message