-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/#review125181
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45067]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 23, 2016, 10:50 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45067/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gives the example `long-lived-framework` enough options to run outside of the build
environment.
>
> This also updates:
>
> * The style of the framework code.
> * Gives the `ExecutorInfo` some resources (needed for some cgroups isolators).
> * Restricts the framework to one agent. Otherwise, it would grab a small chunk of every
machine in the cluster.
> * Adds filters for declined offers.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp 0000289a0b9dd3d1ce30f20dd9bb381126bff30c
>
> Diff: https://reviews.apache.org/r/45067/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran this on the master node on a Mesos cluster:
> ```
> ./long-lived-framework --master=zk://localhost:2181/mesos --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor"
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
|