mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 44707: Added validation for task's kill policy.
Date Tue, 22 Mar 2016 17:10:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44707/
-----------------------------------------------------------

(Updated March 22, 2016, 5:10 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Added a test.


Bugs: MESOS-4909
    https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
  src/tests/master_validation_tests.cpp 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d 

Diff: https://reviews.apache.org/r/44707/diff/


Testing
-------

On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="TaskValidationTest.KillPolicyGracePeriodIsNonNegative" ./bin/mesos-tests.sh
--gtest_repeat=100 --gtest_break_on_failure`


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message