mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 44084: Windows: Forked os::rename().
Date Mon, 21 Mar 2016 21:03:24 GMT


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 234
> > <https://reviews.apache.org/r/44084/diff/1/?file=1304560#file1304560line234>
> >
> >     ```
> >     ASSERT_TRUE(0u, file2Contents.get());
> >     ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 238
> > <https://reviews.apache.org/r/44084/diff/1/?file=1304560#file1304560line238>
> >
> >     ```
> >     ASSERT_TRUE(1u, allFiles.get().size());
> >     ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 248
> > <https://reviews.apache.org/r/44084/diff/1/?file=1304560#file1304560line248>
> >
> >     ```
> >     ASSERT_TRUE(1u, allFiles.get().size());
> >     ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
-----------------------------------------------------------


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 7b2215208bcaa5613426d8ede9cab21d1a084631

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83

> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message