mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 44709: Allowed unknown flags in command and docker executors.
Date Fri, 18 Mar 2016 20:41:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44709/#review124280
-----------------------------------------------------------



Bad patch!

Reviews applied: [44709, 44662, 44661, 44660, 44658, 44657, 45040, 44707, 44656, 44994, 45039,
44993, 44992, 44991, 44854, 44655, 44654, 44653, 44651]

Failed command: ./support/apply-review.sh -n -r 44657

Error:
2016-03-18 20:41:36 URL:https://reviews.apache.org/r/44657/diff/raw/ [7055/7055] -> "44657.patch"
[1]
error: patch failed: src/launcher/executor.cpp:722
error: src/launcher/executor.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12037/console

- Mesos ReviewBot


On March 18, 2016, 5:24 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44709/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:24 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We allow unknown flags to ensure that when a new flag is added
> in Mesos version N, agent of version N works with the executor
> of version N-1, i.e. the latter does not segfault when observing
> a newly introduced flag.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/44709/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message