mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.
Date Fri, 18 Mar 2016 18:51:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
-----------------------------------------------------------



Looks good to me. Couple of things before this can get committed.

--> Have you sent an email to dev/user list about this backwards incompatible change? If
not, you should.
 
--> If users are depending on the return code (need to ask on the above email) we need
to do a proper deprecation warning in 0.29.0 CHANGELOG (Deprecations section) and change the
behavior in 0.30.0.

--> If no one is depending on the return code, we might just do the change in 0.29.0. This
should go into the 0.29.0 CHANGELOG though (API Changes section).

- Vinod Kone


On March 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: mesos-4580
>     https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan <guojiannan@cn.ibm.com>
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/master/create-volumes.md 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 81185a161498394020a27f1f5bf747bac5425f43

>   src/tests/reservation_endpoints_tests.cpp f95ae7a32c3809d150adf1e9e515a3b527e61699

> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message