mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
Date Fri, 18 Mar 2016 14:48:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Bugs: MESOS-4033
    https://issues.apache.org/jira/browse/MESOS-4033


Repository: mesos


Description
-------

This review request tries to add a commit hook for checking non-ascii
characters. It scans .cpp, .hpp, .cc, .h, and .md files and report
error if non-ascii characters exists.

As part of this review request, two non-ascii characters are identified
in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
accordingly.


Diffs
-----

  docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
  support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
  support/non-ascii.py PRE-CREATION 

Diff: https://reviews.apache.org/r/45033/diff/


Testing
-------

Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of
this review request).


Thanks,

Yong Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message