mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Review Request 45016: Fixed Python build breakage.
Date Fri, 18 Mar 2016 05:39:34 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Joris Van Remoortere.

Repository: mesos


Commit cf2ba377e95f8 vendored a more recent upstream version of the
AX_CXX_COMPILE_STDCXX m4 macro. This new version changed behavior: the
old version updated $CXXFLAGS to add the flags necessary to enable
C++11 mode, while the new version updated $CXX.

Updating $CXX mostly works fine, except that for some reason Python's
distutils uses $CC to compile C++ source files for a native Python
extension. There's already a hack in `` to add $CXXFLAGS
to $CFLAGS to workaround this, but the hack stopped working when we
stopped adding the C++ dialect flag to $CXXFLAGS.

For now, revert the m4 macro to update $CXXFLAGS instead of $CXX; in
the future, it might also be worth looking into whether there's a way
to convince distutils to be more sane.

----- a31f154198dc486d6ce0f58fecc35a1eb53b0ff5 
  m4/ax_cxx_compile_stdcxx.m4 fa5463103b9bb641e8840abafe0c40cecf9999a0 



"make check" with GCC 5.3


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message