mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.
Date Tue, 15 Mar 2016 15:29:07 GMT


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181
> > <https://reviews.apache.org/r/44555/diff/1/?file=1293049#file1293049line177>
> >
> >     Again, this check should be removed to support containers that do not specify
NetworkInfo.

We do support containers that do not specify NetworkInfo, please take a look at the diff of
https://reviews.apache.org/r/44514/, in `prepare()`, if the container does not specify NetworkInfo,
then it will not do anything (just a no-op) and subsequently `isolate()` will not do anything
for this kind of container too.

So my idea is, if operator decides to use `network/cni` isolator, then s/he must specify CNI
network configuration and plugin which should be acceptable since CNI isolator needs CNI network
configuration and plugin sounds a reasonable requirement to me. But for framework, they do
not have to launch container to join CNI network, if they do not want a container to join
any CNI networks, then just do not specify NetworkInfo or specify NetworkInfo without `name`
field, we should definitly support it.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
-----------------------------------------------------------


On March 15, 2016, 11:02 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message