mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.
Date Tue, 15 Mar 2016 13:16:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44836/#review123653
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44836]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 15, 2016, 7:49 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44836/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Current WebUI sorts taskId lexically, which results in non-intuitive ordering.
> This patch updates long_lived_framework to use `000001`, `000002` instead.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_framework.cpp 0000289a0b9dd3d1ce30f20dd9bb381126bff30c 
> 
> Diff: https://reviews.apache.org/r/44836/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> In addition, `long_lived_framework` is ran and we confirm correct sorting of `TaskID`
in WebUI
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message