mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 44515: Added agent flags for HTTP authentication.
Date Tue, 15 Mar 2016 10:34:58 GMT


> On March 15, 2016, 10:33 a.m., Joerg Schad wrote:
> > src/slave/flags.cpp, line 682
> > <https://reviews.apache.org/r/44515/diff/8/?file=1296989#file1296989line682>
> >
> >     As we are actively deprecated the old text based format with Mesos-228, does
it make sense to only document the new json format here?

Mesos-2281


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review123630
-----------------------------------------------------------


On March 14, 2016, 4:17 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
>     https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flags for HTTP authentication.
> 
> Three command-line flags have been added to the agent to enable HTTP authentication:
`--authenticate_http`, `--http_credentials`, and `--http_authenticators`.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 4110061d576d5e20e512e84bb049b6ac910ceab0 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a 
> 
> Diff: https://reviews.apache.org/r/44515/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message