mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.
Date Tue, 15 Mar 2016 07:55:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/
-----------------------------------------------------------

(Updated 三月 15, 2016, 7:55 a.m.)


Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-4886
    https://issues.apache.org/jira/browse/MESOS-4886


Repository: mesos


Description
-------

Enabled mesos containerizer force_pull_image for docker.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a

  src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96


Diff: https://reviews.apache.org/r/44838/diff/


Testing
-------

make
make check

It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image`
as true and found that the iamge was always pulled when `force_pull_image` is true.


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message