mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 44767: Added authentication information to master endpoints.
Date Mon, 14 Mar 2016 08:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44767/#review123378
-----------------------------------------------------------




src/master/http.cpp (lines 333 - 335)
<https://reviews.apache.org/r/44767/#comment185623>

    I thought /scheduler wasn't authenticated yet?



src/master/http.cpp (lines 550 - 551)
<https://reviews.apache.org/r/44767/#comment185624>

    This should really just be a boolean that gets translated to the boilerplate text prior
to rendering.



src/master/http.cpp (line 837)
<https://reviews.apache.org/r/44767/#comment185625>

    s/"This...."/false/


- Adam B


On March 13, 2016, 11:18 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44767/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 11:18 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master endpoints now display information whether authentication (if enabled) is required
in HELP.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/master/api/v1/scheduler.md 7a75fd75eef458f26f9e5067b792329f310d5d24

>   docs/endpoints/master/create-volumes.md 2ab116a16581fc5cfc0fc5cf70c6e001a28d8493 
>   docs/endpoints/master/destroy-volumes.md 88679fe12baf7642b63e71688b90031aaedab1ef 
>   docs/endpoints/master/flags.md 739d6bfae5ae35223d6bc7c4782ff0f16b868018 
>   docs/endpoints/master/frameworks.md 95c1f0e63f6a61d0e6622a8ec9d821a646656cfc 
>   docs/endpoints/master/health.md 7f9352025a6364b812b91e9ccbe380a3a69ba4e1 
>   docs/endpoints/master/machine/down.md 6eec9ecc6e92fd1299b27499f78055c6f4f68e81 
>   docs/endpoints/master/machine/up.md 7cbbf04859a218f90672453e5037480676f79fe5 
>   docs/endpoints/master/maintenance/schedule.md 2b5e782554136c1624483d8155a96472ec0660dd

>   docs/endpoints/master/maintenance/status.md 4d0c7551acb89fb375834fd703c406d68f8bdcfc

>   docs/endpoints/master/observe.md fae1ee062350d7b25775bef98a0bebda1892ab62 
>   docs/endpoints/master/quota.md 812874d2dd6c3548887e3044ba1f3c3c8c9d1dd6 
>   docs/endpoints/master/redirect.md ac9d0fa3eae485726b10a3ac756228d0cb5aeb27 
>   docs/endpoints/master/reserve.md 1a4f67961baf761f79a693780f42a1a8ce2244fc 
>   docs/endpoints/master/roles.json.md 863715386791ef9192f38bf390fcd2b31d988547 
>   docs/endpoints/master/roles.md 171e0163c4c2db34bf34c8303846793f3c29bdf5 
>   docs/endpoints/master/slaves.md ec169c15507d3c731b8833f2656949caf0efcc33 
>   docs/endpoints/master/state-summary.md fb10ac7db5b94ea7982c245f1d884312d818c6b5 
>   docs/endpoints/master/state.json.md 0415cfdd63cee0b350b3e33c496bacfc1ba53f8a 
>   docs/endpoints/master/state.md ae1ec718b8d718718727dbd2e7ce4739cca41680 
>   docs/endpoints/master/tasks.json.md 46a1253d33cdfdca0a7158808d1e29da1a634933 
>   docs/endpoints/master/tasks.md 2ada97b5dfdaf5f1f7578fa42eb4e61233e6a753 
>   docs/endpoints/master/teardown.md f68d083a4271ed7dd0ddcc87da104a43eb40c7ec 
>   docs/endpoints/master/unreserve.md e059d8d888343c5036346f7a615f04375f44f517 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 
> 
> Diff: https://reviews.apache.org/r/44767/diff/
> 
> 
> Testing
> -------
> 
> Viewed master endpoint help in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message