mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
Date Fri, 11 Mar 2016 21:40:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review122832
-----------------------------------------------------------



I think you should send an email to the user and dev mailing lists to ask for high-level feedback
on this interface.  We want to make sure the interface is broad enough to support different
implementations.  (And I'm no expert on leader election.)


include/mesos/master/contender.hpp (lines 35 - 37)
<https://reviews.apache.org/r/44287/#comment184928>

    Micro-nit: We prefer the java-doc comment style for new public headers.  You might as
well make the change.
    
    ```
    /**
     * Comment...
     */
    ```



include/mesos/master/contender.hpp (lines 41 - 47)
<https://reviews.apache.org/r/44287/#comment184925>

    Can you expand on these comments a bit?
    
    I think the comments should touch upon:
    
    - `create` exists for backwards compatibility.
    - `create` only works for the Standalone and Zookeeper types.  (Also add something about
the expected input format.)
    - `createFromModule` takes a symbol and creates a module.  Any configuration for this
method should live in the `--modules` flag as a `Parameters` object.
    - `createFromModule` can return the Standalone type, or any other type (assuming you convert
the Zookeeper one into an example module).
    
    Ditto for the detector.


- Joseph Wu


On March 10, 2016, 3:45 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 3:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector implementations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44287/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44289/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message