mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 44554: Added agent HTTP authentication to the docs.
Date Fri, 11 Mar 2016 15:10:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/#review123146
-----------------------------------------------------------




docs/authentication.md (line 12)
<https://reviews.apache.org/r/44554/#comment185321>

    s/certain/most (I can also change that while adding authn to master endpoints).



docs/configuration.md (line 1005)
<https://reviews.apache.org/r/44554/#comment185319>

    We should add a clarification what this credential is used for (because otherwise we have
have twice the same text): "This credential is used to identify the slave to the master."



docs/configuration.md (line 1276)
<https://reviews.apache.org/r/44554/#comment185320>

    Here the use of the credentials is more obvious (compared to credential flag above). Maybe
we should still add a description like:
    These credentials are used to....


- Joerg Schad


On March 11, 2016, 10:04 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44554/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4850
>     https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent HTTP authentication to the docs.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
>   docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
>   docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd 
> 
> Diff: https://reviews.apache.org/r/44554/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message