mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Fri, 11 Mar 2016 05:42:23 GMT


> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote:
> > include/mesos/v1/mesos.proto, lines 1543-1544
> > <https://reviews.apache.org/r/42516/diff/12/?file=1251685#file1251685line1543>
> >
> >     We're going to introduce a ContainerInfo.NetworkInfo.name to allow frameworks
to specify the network they want to join. Note that  NetworkInfo in ContainerInfo is repeated
which allows us to express the situation where a container wants to join multiple networks.
> >     
> >     As we did for ContainerInfo.volumes, I think command configurations for a container
should go to top level. This also avoids the confusion that 'network_name' is set in DockerInfo
while there's another NetworkInfo.name.
> >     
> >     I think what I am proposing is that: we add a NetworkInfo.name, and if DOckerInfo.network
is not set and NetworkInfo.name is set, the docker containerizer will do --net=<NetworkInfo.name>.
> 
> Guangya Liu wrote:
>     Does it make sense to use the `repeated string groups` field in NetworkInfo? I think
that we can treate the groups as different user defined networks. If we added `repeated string
names` field, then what are the difference between those two fields?
>     
>     `
>     // A group is the name given to a set of logically-related interfaces that
>     // are allowed to communicate among themselves. Network traffic is allowed
>     // between two container interfaces that share at least one network group.
>     // For example, one might want to create separate groups for isolating dev,
>     // testing, qa and prod deployment environments.
>     repeated string groups = 3;
>     `
> 
> Jie Yu wrote:
>     What i am suggesting is to add a singular name field:
>     ```
>     message NetworkInfo {
>       optional string name;
>     }
>     ```
>     
>     NetworkInfo itself is repeated in ContainerInfo
> 
> Guangya Liu wrote:
>     Thanks Yu Jie, still a bit confused, can you please explain more? :-)
>     
>     What is the advantage of adding the following instead of `optional string network_name
= 8;`? 
>     
>     message NetworkInfo {
>       optional string name;
>     }
>     
>     Also once add a singular `NetworkInfo`, do we still need to add the `optional string
network_name` field?
> 
> Qian Zhang wrote:
>     I think what we are going to do is to add a singular `name` field in the existing
`NetworkInfo` message rather than to add a singular `NetworkInfo` message.
> 
> Guangya Liu wrote:
>     @Ezra, FYI, There is a JIRA https://issues.apache.org/jira/browse/MESOS-4758 trying
to add `name` to `NetworkInfo`
> 
> Ezra Silvera wrote:
>     @gyliu - is https://issues.apache.org/jira/browse/MESOS-4758 already merged?  If
not I suggest to merge this change and then when that request is merged we can easily go and
change the code to use that field. It seems we keep moving gin circles here on a relatively
simple change which prohibit us to use user-networks from our Swarm based cloud..
> 
> Guangya Liu wrote:
>     @Ezra, not yet. I think that you can get some comments from @jieyu for this.
> 
> Jie Yu wrote:
>     @Ezra @gyliu, sorry about the delay. MESOS-4758 just got merged.

@Ezra,I think that you can rebase ur patch now,  it would be great if your patch can catch
up 0.28 rc1


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119730
-----------------------------------------------------------


On 二月 16, 2016, 12:39 p.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated 二月 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message