mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 44515: Added agent flags for HTTP authentication.
Date Thu, 10 Mar 2016 15:52:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/
-----------------------------------------------------------

(Updated March 10, 2016, 3:52 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.


Changes
-------

Addressed comments.


Bugs: MESOS-4849
    https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
-------

Added agent flags for HTTP authentication.

Three command-line flags have been added to the agent to enable HTTP authentication: `--authenticate_http`,
`--http_credentials`, and `--http_authenticators`.


Diffs (updated)
-----

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 

Diff: https://reviews.apache.org/r/44515/diff/


Testing
-------

`sudo make check` was used to test on both OSX and Ubuntu 14.04.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message