mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.
Date Mon, 07 Mar 2016 20:56:19 GMT


> On March 7, 2016, 7:39 p.m., Joseph Wu wrote:
> > src/tests/persistent_volume_tests.cpp, lines 295-299
> > <https://reviews.apache.org/r/44408/diff/3/?file=1281652#file1281652line295>
> >
> >     Nit: An arrangement like this is preferable:
> >     ```
> >       FrameworkInfo frameworkInfo = DEFAULT_FRAMEWORK_INFO;
> >       frameworkInfo.set_role("role1");
> >       
> >       MockScheduler sched;
> >       MesosSchedulerDriver driver(
> >           &sched, frameworkInfo, master.get(), DEFAULT_CREDENTIAL);
> >     ```

Thanks for the review Joseph. Just updated the review request, and also add Adam to the reviewer
list. Let me know if there are any other issues.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44408/#review122346
-----------------------------------------------------------


On March 7, 2016, 8:55 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44408/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Adam B and Joseph Wu.
> 
> 
> Bugs: MESOS-4868
>     https://issues.apache.org/jira/browse/MESOS-4868
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix removes the setting up of ACLs in PersistentVolumeTests
> as it is no longer needed any more with implicit roles (MESOS-4868).
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
> 
> Diff: https://reviews.apache.org/r/44408/diff/
> 
> 
> Testing
> -------
> 
> make check (in Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message