mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.
Date Fri, 04 Mar 2016 23:43:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43614/
-----------------------------------------------------------

(Updated March 4, 2016, 3:43 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
-------

A couple of comment changes (Bernd's comments & a stale comment that I noticed in one
of the `StartMaster` helpers).


Bugs: MESOS-4633 and MESOS-4634
    https://issues.apache.org/jira/browse/MESOS-4633
    https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
-------

Updates `StartMaster` and `StartSlave` test helpers to use the reworked `cluster` helpers.
 Removes all `MesosTest` cleanup logic and as well as the helpers that accept a `MockExecutor`
pointer.


Diffs (updated)
-----

  src/tests/mesos.hpp d36840f6e23e5823332de53061bf6852330bdf0b 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 

Diff: https://reviews.apache.org/r/43614/diff/


Testing
-------

Tests are run at the end of this review chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message