> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line134>
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, because
the `Docker::create` will add `unix:` automatically.
>
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://xxxx`.
>
> Guangya Liu wrote:
> Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the `Docker::create`
already added `unix:` prefix, the format of `docker_socket` should be `tcp://0.0.0.0:2375,
/var/run/docker.sock`
>
> haosdent huang wrote:
> I think still could, when we pass unix:///var/run/docker.sock as docker_socket. It
would go into this, right?
>
> ```
> if (strings::startsWith(socket, "/")) {
> docker_ = new Docker(path, "unix://" + socket);
> } else {
> docker_ = new Docker(path, socket); <--- If we use unix:///xxxx
> }
> ```
Yes, then what about update the configuration.md, flags.cpp etc by adding unix:///var/run/docker.sock
as a valid option?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
-----------------------------------------------------------
On 三月 4, 2016, 3:13 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
>
> (Updated 三月 4, 2016, 3:13 a.m.)
>
>
> Review request for mesos, Klaus Ma and Timothy Chen.
>
>
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make docker_socket option support different protocols.
>
>
> Diffs
> -----
>
> docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c
> docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
> src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109
> src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534
>
> Diff: https://reviews.apache.org/r/39939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
|