mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.
Date Thu, 03 Mar 2016 04:50:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44266/#review121788
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/examples_tests.cpp (line 27)
<https://reviews.apache.org/r/44266/#comment183626>

    s/EventCall/TestHTTP/


- Vinod Kone


On March 3, 2016, 4:27 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44266/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 4:27 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-4583
>     https://issues.apache.org/jira/browse/MESOS-4583
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change rename event_call_framework to test_http_framework
> in order to correctly reflect that it's an example for HTTP based
> framework. (MESOS-4583)
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am fe549a881e778e094d3f957e5119eeb2f55e7915 
>   src/examples/event_call_framework.cpp d07d05d4b1eae5d2286d3fc1fdc32247bc19cada 
>   src/tests/event_call_framework_test.sh cddb5208bce29cf84c40ff76aff0163d110a98d1 
>   src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 
> 
> Diff: https://reviews.apache.org/r/44266/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message