mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernd Mathiske <be...@mesosphere.io>
Subject Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.
Date Wed, 02 Mar 2016 15:28:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43614/#review121656
-----------------------------------------------------------




src/tests/mesos.hpp (line 133)
<https://reviews.apache.org/r/43614/#comment183412>

    So this injection is allowed to be a shared_ptr and the others are not? This makes me
wonder if it would not be simpler if all injections were shared_ptr, even the ones that are
sometimes Owned and sometimes not (i.e. declared with a parallel member of type *). Then we
would only need one kind for all cases and a lot of code would look substantially simpler.
The only Owned ones would be those that are always Owned.


- Bernd Mathiske


On Feb. 16, 2016, 2:15 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43614/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
>     https://issues.apache.org/jira/browse/MESOS-4633
>     https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updates `StartMaster` and `StartSlave` test helpers to use the reworked `cluster` helpers.
 Removes all `MesosTest` cleanup logic and as well as the helpers that accept a `MockExecutor`
pointer.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43614/diff/
> 
> 
> Testing
> -------
> 
> Tests are run at the end of this review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message