mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.
Date Wed, 02 Mar 2016 11:37:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44260/#review121624
-----------------------------------------------------------




src/master/allocator/mesos/metrics.hpp (line 23)
<https://reviews.apache.org/r/44260/#comment183369>

    s/</"
    s/>/"
    
    We use <> only for "library" or public includes: libprocess, stout, mesos, etc



src/master/allocator/mesos/metrics.hpp (line 33)
<https://reviews.apache.org/r/44260/#comment183370>

    Let's rename the variable to avoid confusion with the namespace. How about `allocator`?



src/master/allocator/mesos/metrics.hpp (line 43)
<https://reviews.apache.org/r/44260/#comment183372>

    Is it what clnag-format suggest? I doubt it : )



src/master/allocator/mesos/metrics.hpp (lines 43 - 44)
<https://reviews.apache.org/r/44260/#comment183373>

    Blank line, please!


- Alexander Rukletsov


On March 2, 2016, 10:35 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44260/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 10:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4718
>     https://issues.apache.org/jira/browse/MESOS-4718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved metrics of the hierarchical allocator to its own file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/master/allocator/mesos/hierarchical.hpp 3043888630b066505410d3b32c5b3f813cc458c1

>   src/master/allocator/mesos/hierarchical.cpp 24fa50f62dec10ed43089297473cc386d6ba2f78

>   src/master/allocator/mesos/metrics.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44260/diff/
> 
> 
> Testing
> -------
> 
> `make distcheck` on OS X, but this patch only adds an unused header. In the follow-up
patch #43879 we use the introduced class successfully.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message