-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44191/#review121391
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44190, 44191]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 1, 2016, 2:26 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44191/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 2:26 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4790
> https://issues.apache.org/jira/browse/MESOS-4790
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We were only using external linkage to workaround bugs in ancient
> (4.1.x) of GCC. We can also mark most of these constants `constexpr`,
> which should be both slightly more efficient (in theory) and
> safer (see MESOS-1023).
>
>
> Diffs
> -----
>
> src/CMakeLists.txt a62042fbd45b46217a88098875524f93d3079de3
> src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17
> src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f
> src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118
>
> Diff: https://reviews.apache.org/r/44191/diff/
>
>
> Testing
> -------
>
> make check
>
> Note that I left a few string constants as `const std::string`; you might arguably want
them to be `constexpr char[]` (per Google Style Guide).
>
>
> Thanks,
>
> Neil Conway
>
>
|