Return-Path: 
 <reviews-return-24894-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9B9AD18038
	for <apmail-mesos-reviews-archive@minotaur.apache.org>;
 Thu, 25 Feb 2016 15:22:28 +0000 (UTC)
Received: (qmail 13028 invoked by uid 500); 25 Feb 2016 15:22:28 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 13007 invoked by uid 500); 25 Feb 2016 15:22:28 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 12987 invoked by uid 99); 25 Feb 2016 15:22:28 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2016 15:22:28 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 804E82A9E1A;
	Thu, 25 Feb 2016 15:22:27 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============0308233655747567633=="
MIME-Version: 1.0
Subject: Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
From: Abhishek Dasgupta <a10gupta@linux.vnet.ibm.com>
To: Timothy Chen <tnachen@apache.org>, Jie Yu <yujie.jay@gmail.com>,
 haosdent huang <haosdent@gmail.com>, Guangya Liu <gyliu513@gmail.com>
Cc: Mesos ReviewBot <reviews@mesos.apache.org>,
 Abhishek Dasgupta <a10gupta@linux.vnet.ibm.com>,
 mesos <reviews@mesos.apache.org>
Date: Thu, 25 Feb 2016 15:22:27 -0000
Message-ID: <20160225152227.1669.48833@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: Abhishek Dasgupta <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/43032/
X-Sender: Abhishek Dasgupta <noreply@reviews.apache.org>
References: <20160225120819.1671.23839@reviews.apache.org>
In-Reply-To: <20160225120819.1671.23839@reviews.apache.org>
Reply-To: Abhishek Dasgupta <a10gupta@linux.vnet.ibm.com>
X-ReviewRequest-Repository: mesos

--===============0308233655747567633==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On Feb. 25, 2016, 12:08 p.m., Guangya Liu wrote:
> > src/docker/docker.cpp, lines 229-251
> > <https://reviews.apache.org/r/43032/diff/10/?file=1267526#file1267526line229>
> >
> >     What about as this:
> >     
> >     Try<Nothing> Docker::validateVersion(const Version& minVersion) const
> >     {
> >       if (dockerVersion < minVersion) {
> >         string msg = "Insufficient version '" + stringify(version.get()) +
> >                      "' of Docker. Please upgrade to >=' " +
> >                      stringify(minVersion) + "'";
> >         return Error(msg);
> >       }
> >     
> >       return Nothing();
> >     }

As we have to use dockerVersion as string, we may expect a parsing error. So that error check is necessary.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review120689
-----------------------------------------------------------


On Feb. 24, 2016, 2:10 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4446
>     https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
>   src/tests/containerizer/docker_containerizer_tests.cpp a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/docker_tests.cpp 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> -------
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


--===============0308233655747567633==--