Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B718C18E24 for ; Wed, 24 Feb 2016 20:03:54 +0000 (UTC) Received: (qmail 44430 invoked by uid 500); 24 Feb 2016 20:03:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 44404 invoked by uid 500); 24 Feb 2016 20:03:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 44381 invoked by uid 99); 24 Feb 2016 20:03:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Feb 2016 20:03:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DFF722A938F; Wed, 24 Feb 2016 20:03:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7446361700309432484==" MIME-Version: 1.0 Subject: Re: Review Request 43960: Added an end-to-end test for docker registry puller. From: Jojy Varghese To: Timothy Chen , Jojy Varghese , Gilbert Song Cc: Jie Yu , mesos Date: Wed, 24 Feb 2016 20:03:53 -0000 Message-ID: <20160224200353.2434.55423@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jojy Varghese X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43960/ X-Sender: Jojy Varghese References: <20160224185110.2433.29816@reviews.apache.org> In-Reply-To: <20160224185110.2433.29816@reviews.apache.org> Reply-To: Jojy Varghese X-ReviewRequest-Repository: mesos --===============7446361700309432484== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/#review120565 ----------------------------------------------------------- src/tests/containerizer/provisioner_docker_tests.cpp (line 360) Would it add value if we assert that the store does not currently have the image? Also, have assertions around the image being placed in the right dircetory? src/tests/containerizer/provisioner_docker_tests.cpp (line 365) Would it make sense to name these as per their semantics? `status1` does not say a lot about them. - Jojy Varghese On Feb. 24, 2016, 6:51 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43960/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 6:51 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added an end-to-end test for docker registry puller. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9 > > Diff: https://reviews.apache.org/r/43960/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > > --===============7446361700309432484==--