Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFF9118C31 for ; Thu, 18 Feb 2016 22:52:10 +0000 (UTC) Received: (qmail 78467 invoked by uid 500); 18 Feb 2016 22:52:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 78436 invoked by uid 500); 18 Feb 2016 22:52:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 78415 invoked by uid 99); 18 Feb 2016 22:52:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Feb 2016 22:52:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D450D2A641A; Thu, 18 Feb 2016 22:52:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5651622995026168277==" MIME-Version: 1.0 Subject: Re: Review Request 43741: Fixed symlink generation for DESTDIR installs. From: Joris Van Remoortere To: James Peach Cc: Kapil Arya , Joris Van Remoortere , mesos Date: Thu, 18 Feb 2016 22:52:08 -0000 Message-ID: <20160218225208.13179.3375@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43741/ X-Sender: Joris Van Remoortere X-ReviewBoard-ShipIt: 1 References: <20160218224916.13179.40355@reviews.apache.org> In-Reply-To: <20160218224916.13179.40355@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============5651622995026168277== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/#review119736 ----------------------------------------------------------- Ship it! Ship It! - Joris Van Remoortere On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43741/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 10:49 p.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-4714 > https://issues.apache.org/jira/browse/MESOS-4714 > > > Repository: mesos > > > Description > ------- > > The install-data-hook was missing the '$(DESTDIR)' prefix. > > > Diffs > ----- > > src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b > > Diff: https://reviews.apache.org/r/43741/diff/ > > > Testing > ------- > > Ran `make install DESTDIR=/tmp` with and without the patch. > > > Thanks, > > Kapil Arya > > --===============5651622995026168277==--