Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7471218268 for ; Thu, 11 Feb 2016 00:01:54 +0000 (UTC) Received: (qmail 37048 invoked by uid 500); 11 Feb 2016 00:01:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37018 invoked by uid 500); 11 Feb 2016 00:01:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37005 invoked by uid 99); 11 Feb 2016 00:01:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 00:01:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 161D129B571; Thu, 11 Feb 2016 00:01:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3697394728517191177==" MIME-Version: 1.0 Subject: Re: Review Request 43453: Added shell flag to mesos-execute to run image default config. From: Jie Yu To: Jie Yu Cc: Gilbert Song , mesos Date: Thu, 11 Feb 2016 00:01:53 -0000 Message-ID: <20160211000153.24150.71574@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43453/ X-Sender: Jie Yu References: <20160210234427.24150.67036@reviews.apache.org> In-Reply-To: <20160210234427.24150.67036@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============3697394728517191177== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43453/#review118769 ----------------------------------------------------------- src/cli/execute.cpp (lines 70 - 71) Just say if the command is a shell or not. If not, 'command' will be treated as value and arguments (TODO). src/cli/execute.cpp (line 208) use CHECK_SOME(command) here src/cli/execute.cpp (lines 209 - 211) Comments here does not sound necessary. Please kill it. src/cli/execute.cpp (line 213) kill this line src/cli/execute.cpp (lines 216 - 217) Why only possible if docker_image is specified? Please remove this comments src/cli/execute.cpp (line 218) Please add a TODO here to treat 'command' as value and arguments. src/cli/execute.cpp (line 326) Can you move 'shell' right above 'command'. Please be consistent and fix other orders as well. - Jie Yu On Feb. 10, 2016, 11:44 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43453/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 11:44 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added shell flag to mesos-execute to run image default config. > > > Diffs > ----- > > src/cli/execute.cpp 4b2244c7449cbba53e4c280c4474557d240b8038 > > Diff: https://reviews.apache.org/r/43453/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > > --===============3697394728517191177==--