Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E52918F71 for ; Fri, 5 Feb 2016 22:35:47 +0000 (UTC) Received: (qmail 97533 invoked by uid 500); 5 Feb 2016 22:35:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 97510 invoked by uid 500); 5 Feb 2016 22:35:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 97483 invoked by uid 99); 5 Feb 2016 22:35:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 22:35:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B66729A936; Fri, 5 Feb 2016 22:35:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4293948294387841768==" MIME-Version: 1.0 Subject: Re: Review Request 42156: Refactored up the common image creation in appc tests. From: Jie Yu To: Jie Yu Cc: Jojy Varghese , mesos Date: Fri, 05 Feb 2016 22:35:46 -0000 Message-ID: <20160205223546.1670.41465@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42156/ X-Sender: Jie Yu References: <20160122064709.32038.94705@reviews.apache.org> In-Reply-To: <20160122064709.32038.94705@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============4293948294387841768== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42156/#review118096 ----------------------------------------------------------- src/tests/containerizer/provisioner_appc_tests.cpp (line 55) Can you add a TODO to move AppcSpecTest to a separate test file (appc_spec_tests.cpp) like we did for docker. src/tests/containerizer/provisioner_appc_tests.cpp (line 127) s/baseDirectory/storeDir/ s/prepareSimpleImageDirectory/createTestImage/ Please also add a comment about what this method is doing? What it is returning? src/tests/containerizer/provisioner_appc_tests.cpp (line 129) No need to do this check. os::mkdir will be a no-op if the directory already exists. src/tests/containerizer/provisioner_appc_tests.cpp (line 177) Could you please use paths::getImagePath here instead? src/tests/containerizer/provisioner_appc_tests.cpp (lines 179 - 180) THis is not 'Rootfs' dir, right? Can you do the following: 1) create rootfs dir (spec::getImageRootfsPath) 2) create tmp under rootfs 3) create the test file src/tests/containerizer/provisioner_appc_tests.cpp (lines 193 - 194) Please use spec::getImageManifestPath - Jie Yu On Jan. 22, 2016, 6:47 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42156/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 6:47 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This change will enable other tests to reuse the common test image creation > logic. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp e3d08d9e49df93d5290099c8bfd917f60c93e51b > > Diff: https://reviews.apache.org/r/42156/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > > --===============4293948294387841768==--