Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9000518607 for ; Wed, 3 Feb 2016 22:55:13 +0000 (UTC) Received: (qmail 96062 invoked by uid 500); 3 Feb 2016 22:55:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 96036 invoked by uid 500); 3 Feb 2016 22:55:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 96018 invoked by uid 99); 3 Feb 2016 22:55:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 22:55:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AB299294AEC; Wed, 3 Feb 2016 22:55:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6863772978853114818==" MIME-Version: 1.0 Subject: Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors. From: Vinod Kone To: Ben Mahler , Vinod Kone Cc: Anand Mazumdar , mesos Date: Wed, 03 Feb 2016 22:55:12 -0000 Message-ID: <20160203225512.1669.94777@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41290/ X-Sender: Vinod Kone References: <20160122203204.7986.8855@reviews.apache.org> In-Reply-To: <20160122203204.7986.8855@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============6863772978853114818== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/#review117684 ----------------------------------------------------------- src/tests/containerizer.hpp (line 140) s/v1callbacks/v1Callbacks/ src/tests/containerizer.hpp (line 144) s/v1mesos/v1Mesos/ src/tests/containerizer.cpp (lines 104 - 108) move this to #163 src/tests/containerizer.cpp (line 116) kill this and just do a contains check below at #164. src/tests/containerizer.cpp (line 157) not yours, but can you fix the indentation here? - Vinod Kone On Jan. 22, 2016, 8:32 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41290/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 8:32 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4457 > https://issues.apache.org/jira/browse/MESOS-4457 > > > Repository: mesos > > > Description > ------- > > This change modifies the `TestContainerizer` class to handle HTTP based executors. Previously, the containerizer test class only used to handle the driver interface. > > > Diffs > ----- > > src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 > src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec > > Diff: https://reviews.apache.org/r/41290/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > > --===============6863772978853114818==--