mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.
Date Mon, 29 Feb 2016 00:37:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/#review121170
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 338)
<https://reviews.apache.org/r/44151/#comment182831>

    It would be cleaner just to pass the vector data directly:
    
    ```C
    ::setgroups(gids.size(), &gids[0])
    ```


- James Peach


On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44151/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 12:08 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
>     https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 84a2a021859d4e5c8547ad2a509eebda428a8255

> 
> Diff: https://reviews.apache.org/r/44151/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message