mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongqiao Wang <yq...@cn.ibm.com>
Subject Re: Review Request 41790: Add tests for /weights endpoint.
Date Sun, 28 Feb 2016 10:22:32 GMT


> On Feb. 27, 2016, 12:21 p.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some indentation
and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
> 
> Yongqiao Wang wrote:
>     Thanks Adam. I will add a couple of registrar tests later in another patches, is
it OK?
> 
> Adam B wrote:
>     Sure, it can go in a later patch, but let's make sure not to forget it.

I have logged a separated JIRA ticket #MESOS-4797 to trace this task.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
-----------------------------------------------------------


On Feb. 27, 2016, 1:55 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> -------
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN      ] DynamicWeightsTest.PutInvalidRequest
> [       OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN      ] DynamicWeightsTest.ZeroWeight
> [       OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN      ] DynamicWeightsTest.NegativeWeight
> [       OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN      ] DynamicWeightsTest.NonNumericWeight
> [       OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN      ] DynamicWeightsTest.MissingRole
> [       OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN      ] DynamicWeightsTest.UnknownRole
> [       OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN      ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [       OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN      ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [       OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [       OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (36 ms)
> [ RUN      ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (527 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (536 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message