mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.
Date Fri, 26 Feb 2016 17:43:08 GMT


> On Feb. 26, 2016, 5:36 a.m., Neil Conway wrote:
> > This needs a prominent note in `upgrades.md` about the change to the ACL format.
Thinking about it, the ACL isn't stored anywhere, so there's no issue with incompatibility
of stored state. Similarly, rolling upgrades should be okay -- a mixed cluster would behave
in a strange way in the event of master failover, but that's probably to be expected.

Good call; I added a note in `upgrades.md`, let me know what you think.


> On Feb. 26, 2016, 5:36 a.m., Neil Conway wrote:
> > docs/authorization.md, line 37
> > <https://reviews.apache.org/r/43800/diff/4/?file=1271103#file1271103line37>
> >
> >     Not yours, but I feel like we need a better way to organize this information.
Maybe a table/matrix, showing the action X is used with subjects Y and objects Z?

Yep, I agree. It seems a bit out of scope for these patches, so I've created a ticket for
this improvement: https://issues.apache.org/jira/browse/MESOS-4785

I'd be happy to take care of it; next sprint perhaps?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/#review120823
-----------------------------------------------------------


On Feb. 26, 2016, 5:33 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43800/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 5:33 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
>     https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs for reservation, volumes, and authZ.
> 
> This updates the authorization documentation to include the new `roles` object for the
`CreateVolume` and `ReserveResources` ACLs. The docs for persistent volumes and dynamic reservations
are also updated to reflect the new authorization behavior. A note has been added to `upgrades.md`
detailing the impact of these changes on upgrades.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/reservation.md b98ebe6df0739b48c5fa58e087fd64b1c6c5d456 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message