mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shuai Lin <linshuai2...@gmail.com>
Subject Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.
Date Thu, 25 Feb 2016 16:22:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43271/#review120714
-----------------------------------------------------------




3rdparty/libprocess/src/subprocess.cpp (line 345)
<https://reviews.apache.org/r/43271/#comment182178>

    Nitpick: would the warning always be logged when forking mesos-fetcher? Because it would
use a copy of `os::environment()`, and #43272 removes the logic that removes `LIBPROCESS_PORT`
from it?


- Shuai Lin


On Feb. 19, 2016, 6:54 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43271/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 6:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4609
>     https://issues.apache.org/jira/browse/MESOS-4609
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Adds a helper method for getting the current environment plus considerations for libprocess.
> * Changes the default behavior of `process::subprocess` to use the above helper when
given `environment = None()`.
> * Adds a warning inside `process::subprocess` if `LIBPROCESS_PORT` conflicts with the
current process's `LIBPROCESS_PORT`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
> 
> Diff: https://reviews.apache.org/r/43271/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Tests are run in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message