mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.
Date Wed, 24 Feb 2016 19:24:51 GMT


> On Feb. 24, 2016, 5:09 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 428
> > <https://reviews.apache.org/r/43880/diff/5/?file=1267210#file1267210line428>
> >
> >     Not yours, but I think we need to update roleSorter when slave active/deactive.
> >     
> >     Filed https://issues.apache.org/jira/browse/MESOS-4755 to trace this.

Dropping this as it is already tracked separately.


> On Feb. 24, 2016, 5:09 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 416
> > <https://reviews.apache.org/r/43880/diff/5/?file=1267210#file1267210line416>
> >
> >     I think we also need to update it in `updateSlave`; if normal resources of agent
is "cpus:16" and Estimator report "mem:10", we'll miss mem in total metrics.

Good catch, the interface certainly allows new resource kinds appearing via `updateSlave`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/#review120511
-----------------------------------------------------------


On Feb. 24, 2016, 11:58 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43880/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4720
>     https://issues.apache.org/jira/browse/MESOS-4720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocator metrics for total and allocated scalar resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 3043888630b066505410d3b32c5b3f813cc458c1

>   src/master/allocator/mesos/hierarchical.cpp 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d

>   src/tests/hierarchical_allocator_tests.cpp 5f771f02db9bd098f3cd36730cd84bf2f5e87a33

> 
> Diff: https://reviews.apache.org/r/43880/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the allocator;
this is partially expected since the added code only inserts metrics in the allocator while
the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers`
on an optimized build under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message