mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 43777: Removed unnecessary parameter from validation function.
Date Wed, 24 Feb 2016 18:41:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 24, 2016, 6:41 p.m.)

Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.



Bugs: MESOS-4591

Repository: mesos

Description (updated)

Removed unnecessary parameter from validation function.

Now that Reserve operations are authorized for particular roles, it is unnecessary to pass
the framework's role into the validation function for Reserve operations. The function previously
ensured that a framework could only reserve resources for its own role, but this check has
been removed. Since this check has been removed, the test `ReserveOperationValidationTest.NonMatchingRole`
is no longer needed and has also been removed.

Diffs (updated)

  src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b 
  src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
  src/master/validation.hpp 6ec883e7e84162b648c2f04583cc776948b36c0c 
  src/master/validation.cpp b0cc7f7ec75b66246686d1b50a61902f1455e8b6 
  src/tests/master_validation_tests.cpp ab2df22f73052f6bd77653e56e7b460b17e7b0be 


Testing (updated)

This patch removes the test `ReserveOperationValidationTest.NonMatchingRole`, as the condition
it was testing for is no longer relevant.

Ran `configure && make check` and `configure --enable-libevent --enable-ssl &&
make check` on OSX; all tests passed.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message