mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 43881: Added allocator metric for the number of allocations to a framework.
Date Tue, 23 Feb 2016 17:09:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Ben Mahler.


Bugs: MESOS-4719
    https://issues.apache.org/jira/browse/MESOS-4719


Repository: mesos


Description
-------

Added allocator metric for the number of allocations to a framework.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 0d39d3f3b5f4ff7f62f9de7200d062845c71818a 
  src/master/allocator/mesos/hierarchical.cpp 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/tests/hierarchical_allocator_tests.cpp 1af5c9870430eb05ca0b19ece0ca2957a05093ff 

Diff: https://reviews.apache.org/r/43881/diff/


Testing
-------

make check (OS X)

I confirmed that this does not lead to general performance regressions in the allocator; this
is partially expected since the added code only inserts metrics in the allocator while the
actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers`
on an optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message