mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Date Tue, 23 Feb 2016 08:44:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
-----------------------------------------------------------

(Updated Feb. 23, 2016, 8:44 a.m.)


Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy Chen.


Bugs: MESOS-4446
    https://issues.apache.org/jira/browse/MESOS-4446


Repository: mesos


Description
-------

Set Docker labels based on TaskInfo labels.


Diffs (updated)
-----

  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
  src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
  src/tests/containerizer/docker_containerizer_tests.cpp a299c9e0744b5657984e5bb0afbe4874a266ddb6

  src/tests/containerizer/docker_tests.cpp 620819330847a10d9dcd817968df9d2b180a9a29 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 

Diff: https://reviews.apache.org/r/43032/diff/


Testing
-------

The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command
through arguments.


Thanks,

Abhishek Dasgupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message