mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 37168: Added example for dynamic reservation features.
Date Mon, 22 Feb 2016 23:23:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120212
-----------------------------------------------------------




src/examples/dynamic_reservation_framework.cpp (line 94)
<https://reviews.apache.org/r/37168/#comment181640>

    Does it make sense to add a comment somewhere explaing the different states and transitions
between them?



src/examples/dynamic_reservation_framework.cpp (line 217)
<https://reviews.apache.org/r/37168/#comment181639>

    LOG(ERROR) << message; or at least add output indicating this is an error.



src/tests/dynamic_reservation_framework_test.sh (line 28)
<https://reviews.apache.org/r/37168/#comment181638>

    Thy do we need this? Comparing to persistent_volume_framework_test.sh



src/tests/dynamic_reservation_framework_test.sh (line 30)
<https://reviews.apache.org/r/37168/#comment181637>

    Thy do we need this? Comparing to persistent_volume_framework_test.sh



src/tests/examples_tests.cpp (line 36)
<https://reviews.apache.org/r/37168/#comment181636>

    additional blank line.


- Joerg Schad


On Feb. 21, 2016, 2:07 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 2:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3063
>     https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message