mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43641: Removed unnecessary parameter from validation function.
Date Mon, 22 Feb 2016 23:06:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120210
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
>     https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary parameter from validation function.
> 
> Since unreserve operations are now possible without a principal, the `bool hasPrincipal`
parameter to the Unreserve operation validation function is no longer necessary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
> 
> Diff: https://reviews.apache.org/r/43641/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message