mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.
Date Mon, 22 Feb 2016 20:10:36 GMT


> On Feb. 22, 2016, 7:30 p.m., Neil Conway wrote:
> > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 286
> > <https://reviews.apache.org/r/43826/diff/1/?file=1264057#file1264057line286>
> >
> >     "Remembering all of these rules is simply too complicated, so we opt to use
a more clever solution."
> 
> Benjamin Bannier wrote:
>     Stongly disagree: *clever* carries a negative connotation, while *solve properly*
is positive.

"So we opt to solve the problem in a different manner." is fine with me also -- I was more
suggesting the sentence flow be rephrased.


> On Feb. 22, 2016, 7:30 p.m., Neil Conway wrote:
> > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 292
> > <https://reviews.apache.org/r/43826/diff/1/?file=1264057#file1264057line292>
> >
> >     The usage "a control flow" is a bit unusual (at least to me). What about "a
program fragment that is easier for the compiler to reason about"?
> 
> Benjamin Bannier wrote:
>     IamNotAComputerScientist, but I believe this is standard compiler lingo (cf. *control
flow graph*).

"control flow" is certainly standard, I just haven't seen it usually referred to as "a control
flow" (in CFG, the object is a "graph"; a CFG is a type of graph).


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/#review120166
-----------------------------------------------------------


On Feb. 22, 2016, 7:48 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43826/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joerg Schad, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   site/source/blog/2016-02-16-synchronized-statements-in-mesos.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43826/diff/
> 
> 
> Testing
> -------
> 
> Locally rendered with `rake && rake dev` from `/site`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message