mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.
Date Mon, 22 Feb 2016 17:00:44 GMT


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 135
> > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line135>
> >
> >     Why not merge this and above `Scheduler API` into one section?

I wanted to keep the Scheduler API i.e. the callbacks the scheduler has to implement and the
calls it can make (i.e. SchedulerDriver API) seperate. Does that make sense?


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, lines 174-178
> > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line174>
> >
> >     Do we need to mention this here? The API was not implemented by the built-in
allocator, so the framework cannot leverage this if using built-in allocator.

It is part of the interface so I believe yes, but I added a note https://reviews.apache.org/r/43838/
stating that the default allocator currently does not implement this call.


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 17
> > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line17>
> >
> >     s/interface/interfaces

a) this is equivalent to the description in scheduler.hpp.
b) For me this is a single interface (specifying several callbacks), what makes you feel this
should be plural?


> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 137
> > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line137>
> >
> >     s/Interface/Interfaces

see above.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/#review120091
-----------------------------------------------------------


On Feb. 22, 2016, 3 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 3 a.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Scheduler-Driver API to app-framework-development-guide.md.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
> 
> Diff: https://reviews.apache.org/r/43819/diff/
> 
> 
> Testing
> -------
> 
> Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and via docker
website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message