mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 43816: Updated `/frameworks` endpoint to use jsonify.
Date Mon, 22 Feb 2016 02:10:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43816/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-4731
    https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
-------

Updated `/frameworks` endpoint to use jsonify.


Diffs
-----

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43816/diff/


Testing
-------

1. make check
2. Verified that after introducing a bug into the jsonify version of `frameworks()`, `make
check` fails (i.e., the test suite covers the `/frameworks` endpoint).
3. Compared output of `/frameworks` with old and new implementation on a test Mesos installation
to try to gauge correctness visually.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message